-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf improvement to getting auth chains #17169
base: develop
Are you sure you want to change the base?
Conversation
5b3845d
to
a2adc9c
Compare
a2adc9c
to
ca79b4d
Compare
@erikjohnston I applied this patch on 1.106.0 and unfortunately it does not really improve. Very long |
46a0c20
to
ca79b4d
Compare
The old code also removed the chains that |
@@ -581,7 +592,7 @@ def fetch_chain_info(events_to_fetch: Collection[str]) -> None: | |||
# are reachable from any event. | |||
|
|||
# (We need to take a copy of `seen_chains` as the function mutates it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment no longer applies.
Let's see if this helps.
--
Regression introduced in #17044
Fixes: #17129
Replaces: #17154