New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hierarchy returning 403 when room is accessible through federation #17194

Open

kfiven wants to merge 3 commits into element-hq:develop from kfiven:patch-2

+25 −2

kfiven commented May 14, 2024

Pull Request Checklist

Fixes #17143

Pull request is based on the develop branch
Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
- Use markdown where necessary, mostly for code blocks.
- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Code style is correct
(run the linters)

kfiven requested a review from a team as a code owner

May 14, 2024 16:59

kfiven added 3 commits

May 18, 2024 09:26


          Fix hierarchy returning 403 when room is accessible through federation

3ef23d6


          Add changelog file

64dda7b


          Fix lint and typecheck

3a4e911

kfiven force-pushed the patch-2 branch from 5319532 to 3a4e911 Compare

May 18, 2024 03:56

erikjohnston reviewed

View reviewed changes

Member

erikjohnston left a comment

Hi, thanks for this. Could you add a unit test and/or a complement test please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment