Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap the top stream ID when fetching changed devices #17197

Closed
wants to merge 3 commits into from
Closed

Cap the top stream ID when fetching changed devices #17197

wants to merge 3 commits into from

Conversation

erikjohnston
Copy link
Member

This just causes us to send down redundant device list updates.

@erikjohnston erikjohnston marked this pull request as ready for review May 15, 2024 14:28
@erikjohnston erikjohnston requested a review from a team as a code owner May 15, 2024 14:28
@erikjohnston erikjohnston mentioned this pull request May 16, 2024
Closed
@erikjohnston erikjohnston marked this pull request as draft May 16, 2024 15:33
@erikjohnston erikjohnston removed the request for review from a team May 16, 2024 15:33
@erikjohnston erikjohnston mentioned this pull request May 18, 2024
Merged
erikjohnston added a commit that referenced this pull request May 21, 2024
@erikjohnston
Improve perf of sync device lists (#17216)
b5facba 
Re-introduces #17191, and includes #17197 and #17214

The basic idea is to stop calling `get_rooms_for_user` everywhere, and
instead use the table `device_lists_changes_in_room`.

Commits reviewable one-by-one.
@erikjohnston
Copy link
Member Author

Landed in #17216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@erikjohnston