Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [dropdown] add props for teleported API #10012

Merged
merged 1 commit into from Oct 27, 2022
Merged

feat(components): [dropdown] add props for teleported API #10012

merged 1 commit into from Oct 27, 2022

Conversation

consultation-applio
Copy link
Contributor

@consultation-applio consultation-applio commented Oct 7, 2022 •
edited

This allows users to decide wether the dropdown should be teleported to the body or not. This make the el-dropdown usable in Vue 3 custom elements. Without teleportation to false, the dropdown is not visible, it positioned outside the view port.

https://vuejs.org/guide/extras/web-components.html

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @consultation-applio, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Oct 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022 •
edited

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Hello @consultation-applio, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@consultation-applio consultation-applio mentioned this pull request Oct 7, 2022
Closed
3 tasks
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 8, 2022
@github-actions
Copy link

github-actions bot commented Oct 8, 2022 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=10012
Please comment the example via this playground if needed.

@consultation-applio
Copy link
Contributor Author

Demo

@tolking tolking requested a review from a team October 18, 2022 04:16
@holazz holazz merged commit edd8b3c into element-plus:dev Oct 27, 2022
@element-bot element-bot mentioned this pull request Nov 6, 2022
Merged
3 tasks
@kaine0923 kaine0923 mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holazz holazz holazz approved these changes

@tolking tolking tolking approved these changes

Assignees

@consultation-applio consultation-applio

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@consultation-applio @holazz @tolking