Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(directives): [click-outside] add shadow dom support #9944

Closed
wants to merge 4 commits into from

Conversation

consultation-applio
Copy link
Contributor

@consultation-applio consultation-applio commented Sep 27, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @consultation-applio, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Sep 27, 2022
@github-actions
Copy link

github-actions bot commented Sep 27, 2022

@github-actions
Copy link

Hello @consultation-applio, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 29, 2022
@github-actions
Copy link

github-actions bot commented Sep 29, 2022

🧪 Playground Preview: https://element-plus.run/?pr=9944
Please comment the example via this playground if needed.

@consultation-applio
Copy link
Contributor Author

consultation-applio commented Oct 5, 2022

This allows users to use Element plus v-click-outside date-picker, time-picker, select and dropdown inside Vue Custom elements.

https://vuejs.org/guide/extras/web-components.html

@consultation-applio
Copy link
Contributor Author

@holazz @chenxch could you please take a look? :)

@consultation-applio
Copy link
Contributor Author

consultation-applio commented Oct 7, 2022

Closing this PR, will opened separate PR for each commit

#10012
#10011
#10010

@HereOrCode
Copy link

Any news?
@holazz @chenxch

@consultation-applio
Copy link
Contributor Author

The content of this PR got moved here:

#12059

but still no luck getting it reviewed. Our company is currently looking at removing element-plus completely from our projects since there’s no way to get web component support even tho we open PR to contribute to get it supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants