Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): delete form validate return and perfect types #16778

Merged
merged 4 commits into from May 12, 2024
Merged

docs(examples): delete form validate return and perfect types #16778

merged 4 commits into from May 12, 2024

Conversation

warmthsea
Copy link
Contributor

@warmthsea warmthsea commented May 7, 2024 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fix: #16776

I think the return value seems to have no meaning, updating the docs is the best way.
or
add return type any ?

@pull-request-triage Pull Request Triage
Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@warmthsea warmthsea closed this May 7, 2024
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=16778
Please comment the example via this playground if needed.

@warmthsea warmthsea reopened this May 7, 2024
@warmthsea warmthsea changed the title docs: delete form exampls validate return value docs(exampls ): delete form validate return value May 7, 2024
@warmthsea warmthsea changed the title docs(exampls ): delete form validate return value docs(exampls): delete form validate return value May 7, 2024
@warmthsea warmthsea changed the title docs(exampls): delete form validate return value docs(exampls): delete form validate return value and perfect types May 7, 2024
@warmthsea warmthsea changed the title docs(exampls): delete form validate return value and perfect types docs(examples): delete form validate return value and perfect types May 7, 2024
@warmthsea warmthsea changed the title docs(examples): delete form validate return value and perfect types docs(examples): delete form validate return and perfect types May 11, 2024
@btea
Copy link
Collaborator

btea commented May 12, 2024

Thanks!

@btea btea merged commit 052af0c into element-plus:dev May 12, 2024
8 checks passed
@btea btea mentioned this pull request May 13, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@warmthsea warmthsea

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TypeScript] [form] FormInstance 中的 validate 方法类型错误
2 participants
@warmthsea @btea