Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: v2.7.2 can not have return value #16685

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

doc: v2.7.2 can not have return value #16685

wants to merge 1 commit into from

Conversation

chengazhen
Copy link

@chengazhen chengazhen commented Apr 27, 2024 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

explain：

the type of FormValidateCallback change to "Promise <void> " from "Promise<false | undefined>"。
the doc need to delete "return false"

1561714212551_ pic

@pull-request-triage Pull Request Triage
Copy link

👋 @chengazhen, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 27, 2024
@github-actions GitHub Actions
Copy link

Hello @chengazhen, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 27, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 28, 2024
@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16685
Please comment the example via this playground if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chengazhen chengazhen

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@chengazhen