Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [autocomplete] the blur event is not triggered #10091

Merged
merged 5 commits into from Mar 1, 2023

Conversation

tolking
Copy link
Member

@tolking tolking commented Oct 14, 2022

closed #9183

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

After the blur event is triggered, determine whether to ignore the current event by judging the position of the current activeElement.

before

after

@github-actions
Copy link

github-actions bot commented Oct 14, 2022

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Oct 14, 2022
@github-actions
Copy link

github-actions bot commented Oct 14, 2022

🧪 Playground Preview: https://element-plus.run/?pr=10091
Please comment the example via this playground if needed.

@tolking tolking requested a review from a team December 12, 2022 13:21
@tolking tolking changed the title fix(components): [autocomplete] the blur event is not triggered WIP: fix(components): [autocomplete] the blur event is not triggered Feb 17, 2023
@tolking tolking changed the title WIP: fix(components): [autocomplete] the blur event is not triggered fix(components): [autocomplete] the blur event is not triggered Feb 17, 2023
@jw-foss
Copy link
Member

jw-foss commented Feb 20, 2023

@tolking looks like the after link was not attached, would you mind uploading a screenshot for that as well?

Copy link
Member

@jw-foss jw-foss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM 👍

@tolking tolking merged commit 5633dfe into dev Mar 1, 2023
@tolking tolking deleted the fix/autocomplete-blur branch March 1, 2023 06:48
@element-bot element-bot mentioned this pull request Mar 3, 2023
3 tasks
loosheng pushed a commit to loosheng/element-plus that referenced this pull request Mar 26, 2023
…ent-plus#10091)

* fix(components): [autocomplete] the blur event is not triggered

closed element-plus#9183

* test(components): [autocomplete] add event:focus

* test(components): [autocomplete] add event:focus

* refactor(components): [autocomplete] optimize code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [autocomplete] Autodcomplete 自动补全输入框失去焦点的时候没有触发 blur方法
2 participants