New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [autocomplete] the blur event is not triggered #10091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Playground Preview: https://element-plus.run/?pr=10091 |
tolking
changed the title
fix(components): [autocomplete] the blur event is not triggered
WIP: fix(components): [autocomplete] the blur event is not triggered
Feb 17, 2023
tolking
changed the title
WIP: fix(components): [autocomplete] the blur event is not triggered
fix(components): [autocomplete] the blur event is not triggered
Feb 17, 2023
3 tasks
@tolking looks like the after link was not attached, would you mind uploading a screenshot for that as well? |
jw-foss
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes LGTM 👍
loosheng
pushed a commit
to loosheng/element-plus
that referenced
this pull request
Mar 26, 2023
…ent-plus#10091) * fix(components): [autocomplete] the blur event is not triggered closed element-plus#9183 * test(components): [autocomplete] add event:focus * test(components): [autocomplete] add event:focus * refactor(components): [autocomplete] optimize code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #9183
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.After the blur event is triggered, determine whether to ignore the current event by judging the position of the current activeElement.
before
after