Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [container] #10469

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Simon-He95
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @Simon-He95, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

Hello @Simon-He95, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Nov 6, 2022
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

🧪 Playground Preview: https://element-plus.run/?pr=10469
Please comment the example via this playground if needed.

@jw-foss
Copy link
Member

jw-foss commented Nov 6, 2022

Hi @Simon-He95, thank you for your work on refactoring components, I think the top priority for the repo right now is sorting the documentation and bug fixing rather than refactoring the code. I know that the code's readability is essential for a large repo that requires collaborations with talented people like you. Please let me know if you are interested in sorting the documentation. Thank you so much for your understanding :D

@jw-foss
Copy link
Member

jw-foss commented Nov 6, 2022

I have some references for you if you are interested in making the documentation clearer:

#10443
#10478

@Simon-He95
Copy link
Contributor Author

I have some references for you if you are interested in making the documentation clearer:

#10443 #10478

ok i will try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants