Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update vitest, jsdom, @vue/test-utils and fix tests #11423

Closed
wants to merge 1 commit into from

Conversation

purepear
Copy link
Contributor

@purepear purepear commented Feb 5, 2023

Update the unit test dependencies to the latest:

  • vitest@0.28.4
  • jsdom@21.1.0
  • @vue/test-utils@2.2.10

Notable changes that required some test refactoring:

Vitest
https://github.com/vitest-dev/vitest/releases/tag/v0.12.10

Jsdom
https://github.com/jsdom/jsdom/releases/tag/16.5.2

  • Fixed radio buttons and checkboxes to not fire input and change events when disconnected.

Vue Test Utils
https://github.com/vuejs/test-utils/releases/tag/v2.2.2

Notable issues

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @purepear, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

Hello @purepear, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Feb 5, 2023
@github-actions
Copy link

github-actions bot commented Feb 5, 2023

🧪 Playground Preview: https://element-plus.run/?pr=11423
Please comment the example via this playground if needed.

@purepear
Copy link
Contributor Author

purepear commented Feb 6, 2023

I'm closing this for now because of TS issues. I'll probably have to update more dependencies in order to get things working properly.

@purepear purepear closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant