New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [select] don't trigger remoteMethod when dropdown hides #13865
Conversation
👋 @yj-liuzepeng, thank you for contributing element-plus. |
Hello @yj-liuzepeng, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=13865 |
I'm not sure if |
Because the input value will be cleared when the drop-down box is closed, I think that triggering the Removing these codes will reproduce the original issues In addition, this PR do not seem to be related to #13847 🤔️ |
Fixed in 2.5.0 |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
The filterMethod or remoteMethod should not be triggered when the dropdown menu is hidden.
Related Issue
Fixes #13847
Related to Issue #9539, #10283, #11614, and PR #9587, #10218
Explanation of Changes
Regarding #9539, I think that when the select is clicked again, it should display the list of search results from the previous search. Additionally, triggering the filterMethod or remoteMethod again when the change event or blur event is triggered could have some negative impacts. I have reviewed other UI component libraries, such as Ant Design and Semi Design, and it is indeed the case.