修复 当 v-infinite-scroll 释放的时候, SCOPE 不存在导致的错误 #14776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @nianwu, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
@nianwu 你是否介意重新修正下代码以及pr标题 |
nianwu
force-pushed
the
fix_infinite_scroll
branch
2 times, most recently
from
a6bdcc6
to
744e736
Compare
|
@chenxch 代码已经修复, 增加了 try_catch 防止出现其他的问题, 请查收 |
nianwu
force-pushed
the
fix_infinite_scroll
branch
from
744e736
to
34c248f
Compare
|
@chenxch 这个标题可以么？ |
ok~ |
|
@nianwu 需要解决一下冲突哦 |
nianwu
force-pushed
the
fix_infinite_scroll
branch
from
bb77597
to
20052a3
Compare
|
@chenxch 请问这样可以了么？ 我把我的分支 rebase 到了 dev 之后, 重新修复了一下代码。 |
|
🧪 Playground Preview: https://element-plus.run/?pr=14776 |
chenxch
approved these changes
Nov 30, 2023
|
@chenxch |
chenxch
reviewed
Dec 5, 2023
| const { container, onScroll } = el[SCOPE] | ||
| if (SCOPE && el[SCOPE]) { | ||
| const container = el[SCOPE] | ||
| const onScroll = el[SCOPE] |
There was a problem hiding this comment.
const { container, onScroll } = el[SCOPE]
| const onScroll = el[SCOPE] | ||
|
|
||
| container?.removeEventListener('scroll', onScroll) | ||
| } | ||
|
|
||
| container?.removeEventListener('scroll', onScroll) |
3 tasks
|
这个Bug已经修复，详情见 #16686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
详见： #14775
Related Issue
Fixes #14775.
Explanation of Changes
🤖 Generated by Copilot at 3c0788e
containerandonScroll(link)