Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): [time-select] export TimeSelectProps and Instance #16511

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

l-x-f
Copy link

@l-x-f l-x-f commented Apr 15, 2024

All other components have been exported props and instance, but timeSelect has not。

// support
import type { FormItemProps } from 'element-plus'

// not support
import type { TimeSelectProps} from 'element-plus'

Copy link

👋 @l-x-f, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 15, 2024
Copy link

Hello @l-x-f, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented Apr 15, 2024

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 15, 2024
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16511
Please comment the example via this playground if needed.

@btea btea requested a review from kooriookami April 25, 2024 12:55
@kooriookami
Copy link
Member

May be we can use withInstall instead. Can refer to https://github.com/element-plus/element-plus/blob/dev/packages/components/affix/index.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants