Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Vue version to 3.4+ / 升级 Vue 的版本至 3.4+ #16546

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

warmthsea
Copy link
Contributor

@warmthsea warmthsea commented Apr 17, 2024

This is a PR that will continue to change until the following plans are completed.
这是一个持续更改的 PR,直至下面的计划完成.

  • Update related deps.
    • vue
    • vite
    • ...
  • Fix type error.
  • Troubleshoot related errors.
  • Add defineSlots support for some component (IDE Slot Tips).
  • Add generic T support for some components.
  • Test.

Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented Apr 17, 2024

Copy link

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16546
Please comment the example via this playground if needed.

@kooriookami
Copy link
Member

Hi,我有个疑问。这会不会导致用户使用低版本Vue会出现某些问题呢?

@warmthsea
Copy link
Contributor Author

Hi,我有个疑问。这会不会导致用户使用低版本Vue会出现某些问题呢?

我觉得Vue3.3、3.4本身对于3.2来讲都没有什么破坏性的更新,都是feature、性能优化,补丁,但是相关库可能有潜在风险,因为相关库大概也要跟随升级版本,比如vue-macros与Vue3.3可能宏冲突、vueuse (升级后tsc至少跑出来几十个错误),当然这些都要处理。

@warmthsea
Copy link
Contributor Author

Hi,我有个疑问。这会不会导致用户使用低版本Vue会出现某些问题呢?

这是一个需要实际检验的问题

@xxholly32
Copy link
Sponsor Contributor

感觉vite 和 vitepress 版本也应该升一下了~
what about vite and vitepress~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants