Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compoents): [message-box] adapt Parameters extraction rules #16592

Merged
merged 2 commits into from Apr 29, 2024

Conversation

reiwang01
Copy link
Contributor

Parameters时会漏掉title: ElMessageBoxOptions['title']

修改后遵从Parameters<Type>:
For overloaded functions, this will be the parameters of the last signature;

Copy link

👋 @reiwang01, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Apr 20, 2024
Copy link

Hello @reiwang01, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented Apr 20, 2024

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 22, 2024
Copy link

github-actions bot commented Apr 22, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16592
Please comment the example via this playground if needed.

@btea btea changed the title fix type error when use Parameters<ElMessageBoxShortcutMethod> fix(compoents): [message-box] adapt Parameters extraction rules Apr 26, 2024
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@btea btea requested a review from kooriookami April 28, 2024 10:09
@btea btea merged commit e75cee1 into element-plus:dev Apr 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants