feat(components): [slider] add mark-snap-percentage #16609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @adapt0, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=16609 |
* while dragging slider; will snap value to the closest mark if value is within mark-snap-percentage (+/- in slider percent) * Snap percentage defaults to zero * can hold down control key while dragging to disable snapping behavior * added additional show-marks examples * generalized mouseDrag in slider tests
adapt0
force-pushed
the
feat/slider/mark-snap-percentage
branch
from
a411857
to
e8b4abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this feature is to be able to drag the slider and easily hit the custom mark values. While a user could just click the mark's label, many users aren't aware of that functionality, and end up struggling to reach the desired mark value. For example a color temperature slider may have a range from 1000K to 10,000K with a default value of 6504K. Getting back to that default 6504K via dragging of the slider can be challenging. Have added this specific case to show-marks examples.
This is also opt-in where the default value of zero keeps previous behavior.
Code does assume that the number of marks will be low, so just performs a linear search of the marks for snapping.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.