New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): [color-picker] add custom trigger #16684
base: dev
Are you sure you want to change the base?
Conversation
👋 @tyj-321, seems like this is your first time contribution to element-plus.
|
🧪 Playground Preview: https://element-plus.run/?pr=16684 |
LGTM. However, you may need to be compatible with other states of |
Sorry, I didn't think it through carefully. But I'm a little confused, why only color-picker uses mask to control the diabled state? example If all use the is-disabled class style, wouldn't the code style be more unified? So I think colorPicker should also use the is-disabled class style, so that there won't be the problem you mentioned above At the same time, using a custom trigger, I think this disabled capability can be given to the custom trigger itself |
The
If |
You are right, so you also think should use the
I need to think of a good way to do this I noticed that when the |
Thank you for raising this question. I think this may be a problem related to |
Do we need a reference slot like Popconfirm? <el-popconfirm title="Are you sure to delete this?">
<template #reference>
<el-button>Delete</el-button>
</template>
</el-popconfirm> |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.