New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [select-v2] with teleported="false"
dropdown closes abnormally
#16714
Open
GUEThe
wants to merge
1
commit into
element-plus:dev
Choose a base branch
from
GUEThe:he/fix/select-v2
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 @GUEThe, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
Their very first contribution
Needs Review
labels
Apr 29, 2024
GUEThe
force-pushed
the
he/fix/select-v2
branch
from
April 29, 2024 13:43
eb178ca
to
1699651
Compare
🧪 Playground Preview: https://element-plus.run/?pr=16714 |
GUEThe
force-pushed
the
he/fix/select-v2
branch
4 times, most recently
from
May 11, 2024 06:25
6e18697
to
c0c6cf0
Compare
GUEThe
force-pushed
the
he/fix/select-v2
branch
2 times, most recently
from
May 13, 2024 15:12
7d749c5
to
1aec499
Compare
Expose listContainerRef, when 'click' event is form listContainerRef and teleported is'false',return 'toggleMenu' function. closed element-plus#16653
btea
changed the title
fix(components): [select-v2] with teleported="false" dropdown closes abnormally
fix(components): [select-v2] with May 19, 2024
teleported="false"
dropdown closes abnormally
btea
approved these changes
May 19, 2024
same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1st contribution
Their very first contribution
CommitMessage::Qualified
Qualified commit message
Contribution::Community
Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.fix #16653 [Component] [select-v2] Virtualized select with teleported="false": When you click on the scrollbar, the dropdown automatically closes