chore: remove ts-nocheck comments in select-v2 #16746
Conversation
|
馃憢 @makedopamine, thank you for contributing element-plus.
|
|
|
|
Hello @makedopamine, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
馃И Playground Preview: https://element-plus.run/?pr=16746 |
|
Found hundreds of |
I actually notice the problem what you say, however, its workload is somewhat heavy to address it completely in a single PR. And I think a large PR is hard for reviewers to review, so I prefer to split the task into separate PRs. |
|
Thanks for your review. There's been a modification, please take a look. |
|
I pushed a new commit, kindly take note. |
makedopamine
force-pushed
the
chore/selectv2_remove_tsnocheck
branch
from
b10e785
to
31abd48
Compare
makedopamine
force-pushed
the
chore/selectv2_remove_tsnocheck
branch
from
76950f3
to
595ea25
Compare
| index: Number, | ||
| index: { | ||
| type: Number, | ||
| required: true, |
There was a problem hiding this comment.
Is setting required required here?
| }, | ||
| height: { | ||
| type: Number, | ||
| required: true, |
| loading: Boolean, | ||
| data: { | ||
| type: Array, | ||
| required: true as const, |
| } | ||
| export const optionEmits = { | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| hover: (index: number) => true, |
There was a problem hiding this comment.
| hover: (index: number) => true, | |
| hover: (index: number) => isNumber(index), |
| visibleChange: (visible: boolean) => true, | ||
| clear: () => true, | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| focus: (event: FocusEvent) => true, |
There was a problem hiding this comment.
| focus: (event: FocusEvent) => true, | |
| focus: (event: FocusEvent) => event instanceof FocusEvent, |
| // eslint-disable-next-line vue/return-in-computed-property | ||
| const validateIcon = computed(() => { | ||
| if (!validateState.value) return | ||
| return ValidateComponentsMap[validateState.value] |
There was a problem hiding this comment.
There seems to be no need to add additional judgment here. If validateState.value does not exist, the returned value should also be undefined.
| __: any, | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| ___: any | ||
| ): Record<string, T> => ({}) |
There was a problem hiding this comment.
It seems that there is no need to add so many comments here, using as should be fine.
const _getItemStyleCache = (_: any, __: any, ___: any) =>
({} as Record<string, T>)
No description provided.