Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): date-picker minDate change unexpectedly #16748

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(components): date-picker minDate change unexpectedly #16748

wants to merge 1 commit into from

Conversation

xiaodong2008
Copy link

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

What's Changed

Fixed #16667.

This PR moved the checking of maxDate.value.isBefore from input event to change event to prevent minDate change unexpectedly.

@pull-request-triage Pull Request Triage
Copy link

👋 @xiaodong2008, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels May 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024 •
edited

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

Hello @xiaodong2008, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@xiaodong2008
Copy link
Author

/label Component::DatePicker

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16748
Please comment the example via this playground if needed.

FrontEndDog
FrontEndDog approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@FrontEndDog FrontEndDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@FrontEndDog FrontEndDog FrontEndDog approved these changes

@kooriookami kooriookami Awaiting requested review from kooriookami

Assignees

@xiaodong2008 xiaodong2008

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
3 participants
@xiaodong2008 @btea @FrontEndDog