Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [form] export fields #16755

Merged
merged 6 commits into from May 7, 2024
Merged

feat(components): [form] export fields #16755

merged 6 commits into from May 7, 2024
+66 −0

Conversation

warmthsea
Copy link
Contributor

@warmthsea warmthsea commented May 6, 2024 •
edited by FrontEndDog

About:
#16747
#16739
#16719

Element-ui

image

Edit after element-plus

image
screenshots

@pull-request-triage Pull Request Triage
Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=16755
Please comment the example via this playground if needed.

@warmthsea
Copy link
Contributor Author

examples

screenshots

FrontEndDog
FrontEndDog approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@FrontEndDog FrontEndDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank!

@FrontEndDog FrontEndDog requested review from tolking and btea May 6, 2024 07:47
btea
btea reviewed May 6, 2024
View reviewed changes
docs/en-US/component/form.md Outdated Show resolved Hide resolved
packages/components/form/src/form.vue Outdated Show resolved Hide resolved
warmthsea and others added 2 commits May 6, 2024 16:05
@warmthsea @btea
Update packages/components/form/src/form.vue
c81bd12 
Co-authored-by: btea <2356281422@qq.com>
@warmthsea @btea
Update docs/en-US/component/form.md
00d8387 
Co-authored-by: btea <2356281422@qq.com>
btea
btea approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking tolking merged commit 1fdbfd0 into element-plus:dev May 7, 2024
8 checks passed
@warmthsea warmthsea deleted the form-export branch May 7, 2024 14:43
@FrontEndDog FrontEndDog mentioned this pull request May 8, 2024
Closed
@element-bot element-bot mentioned this pull request May 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

@FrontEndDog FrontEndDog FrontEndDog approved these changes

Assignees

@warmthsea warmthsea

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@warmthsea @tolking @btea @FrontEndDog