New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): [slider] support model-value and fix change event error #16777
base: dev
Are you sure you want to change the base?
Conversation
🧪 Playground Preview: https://element-plus.run/?pr=16777 |
return `${ | ||
((props.modelValue - min.value) / (max.value - min.value)) * 100 | ||
}%` | ||
return ((props.modelValue - min.value) / (max.value - min.value)) * 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic here seems to be the same as before, and there should be no need to change it. 🤔
if (props.modelValue === undefined) return | ||
|
||
if (props.range) { | ||
if (Array.isArray(props.modelValue)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (Array.isArray(props.modelValue)) { | |
if (isArray(props.modelValue)) { |
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.test case
fixed #14998