Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [table] getColumnIndex is undefined when unmount #16781

Closed
wants to merge 1 commit into from

Conversation

Liao-js
Copy link
Contributor

@Liao-js Liao-js commented May 7, 2024

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Copy link

👋 @Liao-js, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

Copy link

github-actions bot commented May 7, 2024

Hello @Liao-js, thank you for contributing to element-plus, please see our guideline to see how to make contribution

Copy link

github-actions bot commented May 7, 2024

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

🧪 Playground Preview: https://element-plus.run/?pr=16781
Please comment the example via this playground if needed.

@btea
Copy link
Collaborator

btea commented May 8, 2024

Can you provide a use case scenario where the error occurs?

@Liao-js
Copy link
Contributor Author

Liao-js commented May 8, 2024

Can you provide a use case scenario where the error occurs?

last night, the PR developer raised a question in my gihub, saying that using el-table in vuedraggable would report an error, causing the execution to fail.I didn’t expect that he submitted a PR this morning. Let me close this PR.

@Liao-js
Copy link
Contributor Author

Liao-js commented May 8, 2024

when I saw his question, I also felt that my code was not rigorous enough. Just mentioned this PR

@Liao-js Liao-js closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants