Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixed @element-plus/build-constants version #16794

Merged
merged 3 commits into from May 15, 2024
Merged

chore: fixed @element-plus/build-constants version #16794

merged 3 commits into from May 15, 2024

Conversation

xxholly32
Copy link
Sponsor Contributor

#16793

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @xxholly32, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Hello @xxholly32, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited

@xxholly32
Copy link
Sponsor Contributor Author

My company has an Intranet npm register, so I did not upload pnpm-lock.yaml

@warmthsea warmthsea mentioned this pull request May 13, 2024
Closed
@warmthsea
Copy link
Contributor

My company has an Intranet npm register, so I did not upload pnpm-lock.yaml

If pnpm-lock.yaml is not changed, the check will fail.
I encountered the same problem #16793.

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 14, 2024
@xxholly32
Copy link
Sponsor Contributor Author

updated lockfile @warmthsea

@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16794
Please comment the example via this playground if needed.

warmthsea
warmthsea reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@warmthsea warmthsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@btea btea changed the title chore: 🤖 fixed @element-plus/build-constants version chore: fixed @element-plus/build-constants version May 15, 2024
@btea btea requested a review from plainheart May 15, 2024 04:54
@plainheart plainheart merged commit 1ecdafb into element-plus:dev May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmthsea warmthsea warmthsea left review comments

@btea btea btea approved these changes

@plainheart plainheart plainheart approved these changes

Assignees

@xxholly32 xxholly32

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xxholly32 @warmthsea @btea @plainheart