Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [table] selection reference when toggleAllSelection #16800

Merged
merged 3 commits into from May 10, 2024
Merged

fix(components): [table] selection reference when toggleAllSelection #16800

merged 3 commits into from May 10, 2024

Conversation

Liao-js
Copy link
Contributor

@Liao-js Liao-js commented May 9, 2024

fix #16796

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @Liao-js, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Hello @Liao-js, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=16800
Please comment the example via this playground if needed.

@Liao-js Liao-js mentioned this pull request May 9, 2024
Closed
@kooriookami kooriookami requested a review from btea May 10, 2024 01:19
btea
btea reviewed May 10, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it convenient to add a test case?

@Liao-js Liao-js changed the title fix(components): [table] selection is not updated when length is 0 fix(components): [table] selection reference when toggleAllSelection May 10, 2024
@btea btea merged commit 43c8f35 into element-plus:dev May 10, 2024
8 checks passed
@xuyimingwork xuyimingwork mentioned this pull request May 11, 2024
Merged
3 tasks
@element-bot element-bot mentioned this pull request May 13, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@kooriookami kooriookami kooriookami approved these changes

Assignees

@Liao-js Liao-js

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [table] Issue happens when listening the select-all event
3 participants
@Liao-js @btea @kooriookami