Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update filter.vue #16803

Closed
wants to merge 1 commit into from
Closed

Update filter.vue #16803

wants to merge 1 commit into from

Conversation

appchenSir
Copy link

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage Pull Request Triage
Copy link

👋 @appchenSir, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels May 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Hello @appchenSir, thank you for contributing to element-plus, please see our guideline to see how to make contribution

warmthsea
warmthsea reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@warmthsea warmthsea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a valid change.

@btea
Copy link
Collaborator

btea commented May 10, 2024

This is an invalid PR and I will close it.

@btea btea closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warmthsea warmthsea warmthsea left review comments

Assignees

@appchenSir appchenSir

Labels
1st contribution Their very first contribution Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@appchenSir @btea @warmthsea