Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [popper] remove unnecessary conditional judgment #16834

Merged
merged 1 commit into from May 13, 2024
Merged

fix(components): [popper] remove unnecessary conditional judgment #16834

merged 1 commit into from May 13, 2024

Conversation

warmthsea
Copy link
Contributor

@pull-request-triage Pull Request Triage
Copy link

👋 @warmthsea, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited

@github-actions GitHub Actions
Copy link

Hello @warmthsea, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions GitHub Actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=16834
Please comment the example via this playground if needed.

@btea btea changed the title fix: delete invalid code fix(components): [popper] remove unnecessary conditional judgment May 13, 2024
btea
btea approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 75b935a into element-plus:dev May 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

Assignees

@warmthsea warmthsea

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@warmthsea @btea