Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [radio] switch to script-setup synatx #7701

Merged
merged 3 commits into from May 17, 2022

Conversation

chenxch
Copy link
Member

@chenxch chenxch commented May 14, 2022

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.
  1. refactor radio via script-setup [Refactor] Refactor Plan #6114
  2. Add RadioInstance/RadioGroupInstance/RadioButtonInstance type

@github-actions
Copy link

github-actions bot commented May 14, 2022

@chenxch chenxch changed the title Refactor/radio script setup refactor(components): [radio] via script-setup synatx May 14, 2022
@chenxch chenxch changed the title refactor(components): [radio] via script-setup synatx refactor(components): [radio] switch to script-setup synatx May 14, 2022
@github-actions
Copy link

github-actions bot commented May 14, 2022

🧪 Playground Preview: https://element-plus.run/?pr=7701
Please comment the example via this playground if needed.

@jw-foss
Copy link
Member

jw-foss commented May 16, 2022

@chenxch Would you mind resolve these conflicts so we can get this shipped?

@chenxch
Copy link
Member Author

chenxch commented May 16, 2022

@chenxch Would you mind resolve these conflicts so we can get this shipped?

no problem.

@chenxch
Copy link
Member Author

chenxch commented May 16, 2022

cc @JeremyWuuuuu

@jw-foss jw-foss self-requested a review May 17, 2022 04:11
@jw-foss
Copy link
Member

jw-foss commented May 17, 2022

Looking good! 👍

@jw-foss jw-foss merged commit b0646b3 into dev May 17, 2022
@jw-foss jw-foss deleted the refactor/radio_script-setup branch May 17, 2022 04:28
@chenxch chenxch mentioned this pull request May 17, 2022
80 tasks
@element-bot element-bot mentioned this pull request May 20, 2022
3 tasks
gjfei pushed a commit to gjfei/element-plus that referenced this pull request Jun 6, 2022
…plus#7701)

* refactor: radio script setup

* refactor: radio script setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants