Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: select inner input reduce 2px when selected length equal 0 #8209

Closed
wants to merge 1 commit into from
Closed

fix: select inner input reduce 2px when selected length equal 0 #8209

wants to merge 1 commit into from

Conversation

youpinyao
Copy link
Contributor

@youpinyao youpinyao commented Jun 10, 2022

fix: select inner input reduce 2px when selected length equal 0

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

fix: select inner input reduce 2px when selected length equal 0
@pull-request-triage
Copy link

👋 @youpinyao, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 10, 2022
@github-actions
Copy link

@github-actions
Copy link

Hello @youpinyao, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@chenxch
Copy link
Member

chenxch commented Jun 23, 2022

@youpinyao Sorry, it was my oversight, didn't see your pr, did an extra fix. You can take a look at #8423 repair plan and look forward to your next pr, I'm very sorry.

@xiaoxian521
Copy link
Member

Hey, thank you very much for your contribution, but here are some conflicts that need to be solved by you. We can continue to review the code after solving. One thing to remind is that if the conflicts is still not resolved after 10 days, sorry, we will close this pr ❤️

@xiaoxian521 xiaoxian521 added the conflict pending need to resolve conflicts label Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1st contribution Their very first contribution conflict pending need to resolve conflicts Contribution::Community Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants