Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [tooltip] not disappear when <keep-alive> change #8301

Merged
merged 1 commit into from Jun 21, 2022
Merged

fix(components): [tooltip] not disappear when <keep-alive> change #8301

merged 1 commit into from Jun 21, 2022

Conversation

BRSunnySunCo
Copy link
Contributor

@BRSunnySunCo BRSunnySunCo commented Jun 16, 2022 •
edited

[Bug Report] [Component] [tooltip] el-tooltip does not disappear when the reference element is in

closed #8287

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @sunnycocosun, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 16, 2022
@github-actions
Copy link

github-actions bot commented Jun 16, 2022 •
edited

@github-actions
Copy link

Hello @sunnycocosun, thank you for contributing to element-plus, please see our guideline to see how to make contribution

fix(components): [tooltip]
65c3dd4 
el-tooltip does not disappear when the reference element is in <keep-alive>

closed #8287
@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 17, 2022
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=8301
Please comment the example via this playground if needed.

@tolking tolking self-requested a review June 17, 2022 06:46
@BRSunnySunCo BRSunnySunCo changed the title fix(components): [tooltip] fix(components): [tooltip] does not disappear when the reference element is in <keep-alive> Jun 17, 2022
@tolking
Copy link
Member

tolking commented Jun 17, 2022

@sunnycocosun the header not more than 72 characters

@BRSunnySunCo BRSunnySunCo changed the title fix(components): [tooltip] does not disappear when the reference element is in <keep-alive> fix(components): [tooltip] in <keep-alive> Jun 17, 2022
@BRSunnySunCo
Copy link
Contributor Author

@tolking I've changed the title. Don't forget to review it

@tolking tolking changed the title fix(components): [tooltip] in <keep-alive> fix(components): [tooltip] not disappear when <keep-alive> change Jun 21, 2022
@tolking tolking merged commit f582165 into element-plus:dev Jun 21, 2022
@element-bot element-bot mentioned this pull request Jul 1, 2022
Merged
3 tasks
@tolking tolking mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

Assignees

@BRSunnySunCo BRSunnySunCo

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] [Component] [tooltip] el-tooltip does not disappear when the reference element is in <keep-alive>
2 participants
@BRSunnySunCo @tolking