fix(components): [dropdown] fix #8311 #8338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dropdown/src/content.vue: `triggeringElementRef` is a reference of `el-button` component, not the `button` dom object. We should get its dom object before passing it to `virtual-ref`. * popper/src/content.vue: `referenceEl` is `triggeringElementRef`, which is a dom object. Because both dom object and its instance function `getBoundingClientRect` are not reactive, watching their changes are of non-sence. It's strange that it worked before v2.2.6, don't know what happened
|
👋 @CarterLi, thank you for contributing element-plus.
|
|
|
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=8338 |
|
It turns out that it was vueuse/vueuse#1657 that broke element-plus. |
7 tasks
|
VueUse has fixed the regression in https://github.com/vueuse/vueuse/releases/tag/v8.7.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggeringElementRefis a reference ofel-buttoncomponent, not thebuttondom object. We should get itsdom object before passing it to
virtual-ref.referenceElistriggeringElementRef, whichis a dom object. Because both dom object and its instance function
getBoundingClientRectare not reactive, watching their changes are ofnon-sence.
It's strange that it worked before v2.2.6, don't know what happened
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.