Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(components): [select] remove duplicate items #8342

Closed
wants to merge 1 commit into from
Closed

improvement(components): [select] remove duplicate items #8342

wants to merge 1 commit into from

Conversation

ryuhangyeong
Copy link
Member

@ryuhangyeong ryuhangyeong commented Jun 18, 2022

Suggest

Description

If collapse-tags-tooltip is used in the current select component, it will be displayed as shown below.

image

You can see that the same element is displayed twice. I think this should be removed.

Why

There is no reason to show the same element twice, and users would think that the tooltip will contain all but the first element.

image

And the number indicated by + is different from the number of items displayed in the actual tooltip.

etc

I think there must have been a good reason why the component was developed like this at the time it was developed. But I thought what I was suggesting would be more intuitive when viewed by users.

Thanks for reading. Any comments would be appreciated!

video

GOMCAM.20220618_1832090692.mp4

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @ryuhangyeong, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 18, 2022

@github-actions
Copy link

Hello @ryuhangyeong, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=8342
Please comment the example via this playground if needed.

@ryuhangyeong
Copy link
Member Author

#8344 Merge from that PR to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant