Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [autocomplete] the popup still appears after select #8350

Merged
merged 1 commit into from Jun 19, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
52 changes: 42 additions & 10 deletions packages/components/autocomplete/src/autocomplete.vue
Expand Up @@ -14,6 +14,8 @@
:transition="`${ns.namespace.value}-zoom-in-top`"
persistent
@before-show="onSuggestionShow"
@show="onShow"
@hide="onHide"
>
<div
ref="listboxRef"
Expand All @@ -38,6 +40,7 @@
@keydown.enter="handleKeyEnter"
@keydown.tab="close"
@keydown.esc="handleKeyEscape"
@mousedown="handleMouseDown"
>
<template v-if="$slots.prepend" #prepend>
<slot name="prepend" />
Expand Down Expand Up @@ -100,7 +103,7 @@ import {
import { debounce } from 'lodash-unified'
import { onClickOutside } from '@vueuse/core'
import { Loading } from '@element-plus/icons-vue'
import { useAttrs, useNamespace } from '@element-plus/hooks'
import { useAttrs, useDisabled, useNamespace } from '@element-plus/hooks'
import { generateId, isArray, throwError } from '@element-plus/utils'
import {
CHANGE_EVENT,
Expand Down Expand Up @@ -130,14 +133,15 @@ const emit = defineEmits(autocompleteEmits)
const attrs = useAttrs()
const rawAttrs = useRawAttrs()
const disabled = useDisabled()
const ns = useNamespace('autocomplete')
const inputRef = ref<InputInstance>()
const regionRef = ref<HTMLElement>()
const popperRef = ref<TooltipInstance>()
const listboxRef = ref<HTMLElement>()
let isClear = false
let ignoreFocusEvent = false
const suggestions = ref<AutocompleteData>([])
const highlightedIndex = ref(-1)
const dropdownWidth = ref('')
Expand All @@ -155,13 +159,31 @@ const suggestionVisible = computed(() => {
const suggestionLoading = computed(() => !props.hideLoading && loading.value)
const refInput = computed<HTMLInputElement[]>(() => {
if (inputRef.value) {
return Array.from<HTMLInputElement>(
inputRef.value.$el.querySelectorAll('input')
)
}
return []
})
const onSuggestionShow = async () => {
await nextTick()
if (suggestionVisible.value) {
dropdownWidth.value = `${inputRef.value!.$el.offsetWidth}px`
}
}
const onShow = () => {
ignoreFocusEvent = true
}
const onHide = () => {
ignoreFocusEvent = false
highlightedIndex.value = -1
}
const getData = async (queryString: string) => {
if (suggestionDisabled.value) return
Expand Down Expand Up @@ -194,24 +216,34 @@ const handleInput = (value: string) => {
emit(UPDATE_MODEL_EVENT, value)
suggestionDisabled.value = false
activated.value ||= isClear && valuePresented
activated.value ||= valuePresented
if (!props.triggerOnFocus && !value) {
suggestionDisabled.value = true
suggestions.value = []
return
}
if (isClear && valuePresented) {
isClear = false
}
debouncedGetData(value)
}
const handleMouseDown = (event: MouseEvent) => {
if (disabled.value) return
if (
(event.target as HTMLElement)?.tagName !== 'INPUT' ||
refInput.value.includes(document.activeElement as HTMLInputElement)
) {
activated.value = true
}
}
const handleChange = (value: string) => {
emit(CHANGE_EVENT, value)
}
const handleFocus = (evt: FocusEvent) => {
if (ignoreFocusEvent) return
activated.value = true
emit('focus', evt)
if (props.triggerOnFocus) {
Expand All @@ -220,12 +252,12 @@ const handleFocus = (evt: FocusEvent) => {
}
const handleBlur = (evt: FocusEvent) => {
if (ignoreFocusEvent) return
emit('blur', evt)
}
const handleClear = () => {
activated.value = false
isClear = true
emit(UPDATE_MODEL_EVENT, '')
emit('clear')
}
Expand All @@ -239,7 +271,6 @@ const handleKeyEnter = async () => {
handleSelect(suggestions.value[highlightedIndex.value])
} else if (props.selectWhenUnmatched) {
emit('select', { value: props.modelValue })
await nextTick()
suggestions.value = []
highlightedIndex.value = -1
}
Expand All @@ -265,7 +296,6 @@ const handleSelect = async (item: any) => {
emit(INPUT_EVENT, item[props.valueKey])
emit(UPDATE_MODEL_EVENT, item[props.valueKey])
emit('select', item)
await nextTick()
suggestions.value = []
highlightedIndex.value = -1
}
Expand Down Expand Up @@ -305,7 +335,9 @@ const highlight = (index: number) => {
)
}
onClickOutside(listboxRef, close)
onClickOutside(listboxRef, () => {
suggestionVisible.value && close()
})
onMounted(() => {
// TODO: use Volar generate dts to fix it.
Expand Down