Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [dropdown] fix A11y when tooltip show #8655

Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix(components): [dropdown] fix A11y when tooltip show #8655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/components/dropdown/src/dropdown.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@
teleported
pure
persistent
@before-show="handleShowTooltip"
@before-hide="handleHideTooltip"
@before-show="handleBeforeShowTooltip"
@show="handleShowTooltip"
@before-hide="handleBeforeHideTooltip"
>
<template #content>
<el-scrollbar
Expand Down Expand Up @@ -191,13 +192,17 @@ export default defineComponent({
}
}

function handleBeforeShowTooltip() {
emit('visible-change', true)
}

function handleShowTooltip(event?: Event) {
if (event?.type === 'keydown') {
contentRef.value.focus()
}
emit('visible-change', true)
}
function handleHideTooltip() {

function handleBeforeHideTooltip() {
emit('visible-change', false)
}

Expand Down Expand Up @@ -245,8 +250,9 @@ export default defineComponent({
handleEntryFocus,
handleClose,
handleOpen,
handleBeforeShowTooltip,
handleShowTooltip,
handleHideTooltip,
handleBeforeHideTooltip,
onFocusAfterTrapped,
popperRef,
contentRef,
Expand Down