Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(directives): [resize] use useResizeObserver #8894

Closed
wants to merge 1 commit into from
Closed

refactor(directives): [resize] use useResizeObserver #8894

wants to merge 1 commit into from

Conversation

Tsong-LC
Copy link
Contributor

addResizeListener and removeResizeListener are deprecated. Use useResizeObserver in vueuse as suggested

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @Tsong-LC, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @Tsong-LC, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jul 19, 2022 •
edited

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=8894
Please comment the example via this playground if needed.

@holazz
Copy link
Member

holazz commented Jul 19, 2022

Hi, I think this directive will be removed in the future, and I've created PRs to do this.

related to #8617, #8618

@Tsong-LC Tsong-LC closed this Jul 20, 2022
@Tsong-LC Tsong-LC deleted the refactor/resize branch July 20, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tsong-LC Tsong-LC

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tsong-LC @holazz