Notebook Tabs: move padding to grid #763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also effects the context menu of the tabs. When right-clicking the within the 3px padding of a tab, instead of the context menu of the the tab the context menu of the tab-bar is shown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #523
Currently there is a padding around the
Granite.Widgets.Tab. So clicks within the 3px edge of the tab are not registered and instead ripple through to theGranite.DynamicNotebook. This can lead to the problem, that when trying to close a tab with Middle or Three-FingerClick an old tab is restored instead.Before (EventArea of
GraniteWidgetsTab)After (EventArea of
GraniteWidgetsTab)