Internal: Conversion Center - Link in Bio - Variation 6 #27322
Conversation
| title = Marionette.TemplateCache.prototype.compileTemplate( titleField )( | ||
| { | ||
| ...this.model.parseDynamicSettings(), | ||
| itemIndex: this.getOption( 'itemIndex' ), |
There was a problem hiding this comment.
@louiswol94 I added this so that the tag was available in title_field and could be used. Do you think that there is a better way of achieveing this?
There was a problem hiding this comment.
@nicoladj77 I do not understand, can you please elaborate a bit more? Tnx.
There was a problem hiding this comment.
@louiswol94 so I am using this here https://github.com/elementor/elementor/pull/27322/files#diff-405e5ccb597bae3aa605f6db5467dffc4a03e6ab37fccff7b27cd2d4e39451beR256
in the mocukp we have to display "Image #1" instead of "Item #1" which is the default title. I checked the repeater code and it uses that itemIndex property which is not exposed for parsing the title_field template. Or at least I didn't see it in parseDynamicSettings() so I exposed it.
There was a problem hiding this comment.
@louiswol94 rolled back changes
PR Checklist
PR Type
What kind of change does this PR introduce?
Summary
This PR can be summarized in the following changelog entry:
Description
An explanation of what is done in this PR
Test instructions
This PR can be tested by following these steps:
Quality assurance
Fixes #