Exercise 10 #15
Exercise 10 #15
Conversation
elenap1991
force-pushed
the
ex10
branch
2 times, most recently
from
3e7b1b4
to
46996af
Compare
due to jest fix jestjs/jest#8005 After this update travis would output real errors of css validation tests
| <form method="GET" action="http://httpbin.org/get"> | ||
| <fieldset> | ||
| <legend>Personal data</legend> | ||
| <label>Surname |
| <fieldset> | ||
| <legend>Personal data</legend> | ||
| <label>Surname | ||
| <input> |
There was a problem hiding this comment.
не хвататет отрибутов type и id
| <br> | ||
| <label>You are | ||
| <input type="radio" name="sex"> | ||
| male</label> |
There was a problem hiding this comment.
Проверь форматирование кода
| text-transform:capitalize; | ||
| } | ||
| .table td:nth-child(4)::before{ | ||
| content:"$"; |
There was a problem hiding this comment.
И тут тоже форматирование поехало
| @@ -0,0 +1,27 @@ | |||
| .table tr:nth-child(odd){ | |||
There was a problem hiding this comment.
Зачем ты используешь тэги, если есть классы у элементов?
There was a problem hiding this comment.
использовала классы, но все же интересно, насколько в данном случае использовать классы целесообразно, ведь код получается длиннее...
| .article{ | ||
| grid-area:article; | ||
| } | ||
| body{ |
| grid-area: articles; | ||
| text-align: justify; | ||
| } | ||
| @media only screen and ( min-width: 1346px){ |
There was a problem hiding this comment.
Вынеси медиа в отдельный файл?
There was a problem hiding this comment.
Разделила на отдельные файлы
| .header__contact-container-item { | ||
| position: relative; | ||
| } | ||
| .header__contact-hint { |
There was a problem hiding this comment.
Тултип должен появляться при наведении на иконку. Для каждой икноки свой тултип
There was a problem hiding this comment.
Добавила тултип при наведении на иконку (цвет иконок при наведении не меняла, не смогла найти svg с конвертом)
| </div> | ||
| <article class="article"> | ||
| <div class="article__background"> | ||
| <div class="article__text"><img src="image/text.png" alt="LET’S DRAW SOME ARTS & make your business much better"></div> |
There was a problem hiding this comment.
Это не должно быть картинкой.
* added attribute `for` in label tags and attributes `id` and `type` in input tags * fixed code formatting * splitted css files * added tooltip when hovering * replaced text image with just text
created adaptive page, page whith spreadsheet, page whith form registration