ipv6 support #1204
Open
ipv6 support #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lsh-0
commented
Nov 21, 2023
•
lsh-0
commented
- fix routing on new subnets before launching new instance
- launch an ipv6 instance, ssh into it and run highstate successfully
- review
these will select either an ipv4 or ipv6 address, prefering ipv4
lsh-0
commented
Jan 23, 2024
lsh-0
commented
Jan 23, 2024
src/buildercore/trop.py
Outdated
| @@ -408,10 +432,12 @@ def ec2_security(context): | |||
| security_group_ports = _convert_ports_to_dictionary(security_group_data) | |||
| ingress = merge_ports(ec2_ports, security_group_ports) | |||
|
|
|||
| ipv6 = context['aws'].get('subnet-ipv6', False) | |||
There was a problem hiding this comment.
not going to work with mixed-ip subnets
lsh-0
commented
Jan 23, 2024
| @@ -20,7 +20,7 @@ def _dummy_instance_is_active(find_ec2_instances, load_context, active_stack_nam | |||
| }, | |||
| } | |||
| instance = MagicMock() | |||
| instance.public_ip_address = '54.54.54.54' | |||
| instance.public_ip_address = '54.54.54.54' # todo | |||
…v6'. the project flags affect more than just subnets. the flags are at the 'aws' level because they'll need to be overwritten on a per-instance basis, rather than a per-project basis.
lsh-0
commented
Feb 14, 2024
projects/elife.yaml
Outdated
| # project supports IPv4 or IPv6 or both. | ||
| # when both are true and circumstances forbid it (ec2 subnets), prefer IPv6 | ||
| use-ipv4: true # create DNS A records, IPv4 CIDRs, use IPv4 subnets | ||
| use-ipv6: false # create DNS AAAA records, IPv6 CIDRs, use IPv6 subnets |
There was a problem hiding this comment.
perhaps just 'ipv4' and 'ipv6' ?
lsh-0
commented
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.