fix: Refine macOS WebView check so that it is false for browsers #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refines check for macOS WebViews (originally implemented in #613) so that it is
false
for Chrome, Safari, etc.User agent for WebView:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_5) AppleWebKit/605.1.15 (KHTML, like Gecko)
Any browser running on macOS will have a similar user agent, but will also have one of these differences (source):
AppleWebKit
in the stringSafari
Additionally, this is restricted to macOS (will be
false
on iOS) by testing forMacintosh
This fix is a bit more comprehensive, as #629 and #637 will still be
true
for SafariFixes #624