Resolve Dialyzer errors on Elixir 1.16 #643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathany-copia
force-pushed
the
dialyzer
branch
from
faff879
to
c6ea3cb
Compare
nathany-copia
commented
Dec 27, 2023
nathany-copia
commented
Dec 27, 2023
|
FYI, I'm seeing a number of test failures (8) locally -- on the |
yordis
reviewed
Dec 28, 2023
yordis
reviewed
Dec 28, 2023
|
@yordis Are there any other changes needed before we can merge this and publish a Tesla release that supports Elixir 1.16? |
|
We need to add OTP 26 to the CI pipeline to make sure it is green |
|
CI updated. I don't think we need any matrix exceptions based on the versions I saw over here, but I'm happy to make other changes. Thanks. |
|
I am looking forward to this being merged :) |
|
Merged in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #642