New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): added greek translation #2831
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@trlef19 why are you closing the PR? Check https://github.com/elk-zone/elk/blob/main/CONTRIBUTING.md#adding-a-new-language |
Add {
code: 'ca',
file: 'ca.json',
name: 'Català',
},
{
code: 'el-GR',
file: 'el-GR.json',
name: 'Ελληνικά',
},
{
code: 'de-DE',
file: 'de-DE.json',
name: 'Deutsch',
}, |
You also need to include plurals if required, check the entry in the contributing guide: https://vue-i18n.intlify.dev/guide/essentials/pluralization.html#custom-pluralization (check also examples in previous config/i18n.ts module) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on the Greek translation 🙂
It looks like there are still remaining English strings. You can choose either 1) to translate all English strings before merging PR, or 2) merge this PR now and translate remaining strings later.
If you want to translate all strings (1), please continue to translate them and let us know once you finish and ready to merge.
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
Co-authored-by: TAKAHASHI Shuuji <shuuji3@gmail.com>
I will translate them all first :)) |
Great work @trlef19 😀 Thanks for translating Elk to Greek 🇬🇷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much! I also double-checked with Google Translate.
(I cannot read modern Greek but it reminded me of the time when I learned basics of ancient Greek in a university lecture years ago 😀)
ancient greek are a real challenge! |
No description provided.