Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): added greek translation #2831

Merged
merged 27 commits into from May 11, 2024
Merged

feat(i18n): added greek translation #2831

merged 27 commits into from May 11, 2024

Conversation

trlef19
Copy link
Contributor

@trlef19 trlef19 commented Apr 18, 2024

No description provided.

Copy link

stackblitz bot commented Apr 18, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit bc84da2
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/663de7e96fbed400085b7566

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit bc84da2
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/663de7e965f2fb0008cc661c
😎 Deploy Preview https://deploy-preview-2831--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trlef19 trlef19 changed the title added greek translation feat(i18n): added greek translation Apr 18, 2024
@trlef19 trlef19 closed this Apr 18, 2024
@trlef19 trlef19 reopened this Apr 18, 2024
@userquin
Copy link
Member

@userquin
Copy link
Member

userquin commented Apr 18, 2024

Add el-GR entry between ca and de-DE here https://github.com/elk-zone/elk/blob/main/config/i18n.ts#L117 (review the name):

{
    code: 'ca',
    file: 'ca.json',
    name: 'Català',
  },
  {
    code: 'el-GR',
    file: 'el-GR.json',
    name: 'Ελληνικά',
  },
  {
    code: 'de-DE',
    file: 'de-DE.json',
    name: 'Deutsch',
  },

@userquin
Copy link
Member

You also need to include plurals if required, check the entry in the contributing guide: https://vue-i18n.intlify.dev/guide/essentials/pluralization.html#custom-pluralization (check also examples in previous config/i18n.ts module)

Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the Greek translation 🙂

It looks like there are still remaining English strings. You can choose either 1) to translate all English strings before merging PR, or 2) merge this PR now and translate remaining strings later.

If you want to translate all strings (1), please continue to translate them and let us know once you finish and ready to merge.

config/i18n.ts Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@trlef19
Copy link
Contributor Author

trlef19 commented Apr 23, 2024

I will translate them all first :))

@trlef19 trlef19 requested a review from shuuji3 May 8, 2024 13:46
locales/el-GR.json Outdated Show resolved Hide resolved
@emanuelpina
Copy link
Contributor

Great work @trlef19 😀

Thanks for translating Elk to Greek 🇬🇷

Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! I also double-checked with Google Translate.

(I cannot read modern Greek but it reminded me of the time when I learned basics of ancient Greek in a university lecture years ago 😀)

@shuuji3 shuuji3 added this pull request to the merge queue May 11, 2024
Merged via the queue into elk-zone:main with commit 65557fa May 11, 2024
13 checks passed
@trlef19
Copy link
Contributor Author

trlef19 commented May 12, 2024

ancient greek are a real challenge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants