refactor: generic components #868
Conversation
|
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -20,7 +20,7 @@ function close() { | |||
| <div> | |||
| <slot /> | |||
| </div> | |||
| <button text-xl hover:text-primary bg-hover-overflow w-1.4em h-1.4em @click="close()"> | |||
There was a problem hiding this comment.
Is there a reason to prefer one or the other? Honest question, so I apply what we think is better next time. Also, maybe there should be a linting rule if we want to promote a single way to use these attrs? cc @antfu
There was a problem hiding this comment.
Because I enabled jsxTemplates for Volar. w-1.4em is not a valid JSX syntax (because of . I guess). So I have to change it.
The linting rule is unnecessary since Volar will emit an error for w-1.4em.
There was a problem hiding this comment.
It's ok to me. I just pushed a feature to UnoCSS to have a common size="" prefix for it: bf434f3f6d1c4d445a82ca0cc97fbbc3e2333b12. We could update it once after next UnoCSS release.
Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
vuejs/language-tools#1964