Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: changed kB to bytes in EWW_RAM description #1075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harshkhandeparkar
Copy link

@harshkhandeparkar harshkhandeparkar commented Apr 20, 2024

Fixes #1074
Please follow this template, if applicable.

Description

The docs mention that EWW_RAM values are in kB but the returned values are in bytes. This PR changes the documentation to mention bytes instead of kB.

Additional Notes

I think changing the documentation is better than returning kB values so that no existing widgets are broken.

Checklist

Please make sure you can check all the boxes that apply to this PR.

  • All widgets I've added are correctly documented.
  • I added my changes to CHANGELOG.md, if appropriate.
  • The documentation in the docs/content/main directory has been adjusted to reflect my changes.
  • I used cargo fmt to automatically format all code before committing

@harshkhandeparkar
Copy link
Author

Should documentation changes be added to the changelog?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] EWW_RAM returning strange values
1 participant