Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1107 (optimized version) #1113

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ForgottenGensym
Copy link

See #1107, this is a more optimized version than just an isInfinite check, because it specifically checks only for positive infinity (the edge case here).

This adds two new Kernel.Basics JS functions (accessible via the associated Basics Elm functions):
isPositiveInfinity and isNegativeInfinity. These are useful for more than just this fix as well.

This isn’t a fix for elm#1107, but a part of a potential one. These `Kernel.Basics` functions will allow a more optimized solution to the `List.repeat` problem
Part of a potential fix elm#1107 (optimized version).
@github-actions
Copy link

github-actions bot commented Jun 1, 2021

Thanks for suggesting these code changes. To set expectations:

  • Pull requests are reviewed in batches, so it can take some time to get a response.
  • Smaller pull requests are easier to review. To fix nine typos, nine specific issues will always go faster than one big one. Learn why here.
  • Reviewers may not know as much as you about certain situations, so add links to supporting evidence for important claims, especially regarding standards for CSS, HTTP, URI, etc.

Finally, please be patient with the core team. They are trying their best with limited resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant