Move createBinding to Binding.fs since it isn't used anywhere else
#506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marner2
force-pushed
the
feature/improve_interop
branch
from
06fcaaa
to
6dd7b74
Compare
marner2
force-pushed
the
feature/improve_interop
branch
3 times, most recently
from
1d6f09c
to
8393249
Compare
marner2
force-pushed
the
feature/improve_interop
branch
2 times, most recently
from
3a6d06b
to
dd0904f
Compare
marner2
force-pushed
the
feature/improve_interop
branch
from
dd0904f
to
81b3932
Compare
marner2
force-pushed
the
feature/improve_interop
branch
2 times, most recently
from
cefd0a3
to
1b664e9
Compare
marner2
changed the title
createBinding to Binding.fs since it isn't used anywhere else
marner2
force-pushed
the
feature/improve_interop
branch
from
1b664e9
to
f534739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge.
Conflicts with #512 because the
createBindingfunction that got moved gets modified there.I ran into an issue where the system didn't like having the
Namefield mentioned first, since it's common with the comingBindingT.Name. Since they differ atDataandDataTrecords, it made sense to just mention those first. Also moved toBinding.fssince it wasn't needed in that other file.