Add Fantomas and require correct formatting #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't reviewed all the code changes, but I have imported the requested |
|
We might want to squash merge this PR. |
In accordance with the .config initiative at https://github.com/dot-config/dot-config.github.io
|
Hi, I want to know: what specifically is "correct formatting"? What will it add to/modify in fantomas? Thank you |
|
@YkTru, I don't understand. What do you want to know that is not in the file diff and the |
|
I meant what "formatting" of Elmish code is recommended, since in the examples there doesn't seem to be a uniform way to format/write Elmish code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #434.
This PR is starting as a work in progress so I can see pipeline results; I'm new to GitHub Actions.