Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove redundant h5 element #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: remove redundant h5 element #34

wants to merge 1 commit into from

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 24, 2021 •
edited

Resolve a11y issue without breaking changes:

Heading levels should only increase by one
Headings must be in a valid logical order, meaning h1 through h6 element tags must appear in a sequentially-descending order.

Closes #26

cc @elviswolcott

@junyper
Copy link

junyper commented Jan 21, 2022

Thanks for fixing this. I hope this is merged soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

h5 element accessibility issue
2 participants
@lex111 @junyper