Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline icon to tab for pipeline editor #261

Merged
merged 1 commit into from Feb 15, 2020
Merged

Conversation

ajbozarth
Copy link
Member

Unlike other tabs, prior to this any pipeline editor tab was missing an icon

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Unlike other tabs, prior to this any pipeline editor tab was missing an icon
@ajbozarth
Copy link
Member Author

Small note: The fix for this on the jupyterlab-2.0 branch will require an update coming in r2 next week (open pr: jupyterlab/jupyterlab/pull/7864) and will have to be address in the final updates to that branch once rc2 is out (that pr will finalize the new icon work and will require a handful of final tweaks on our end)

@lresende lresende merged commit 8175448 into master Feb 15, 2020
@ajbozarth ajbozarth deleted the ajbozarth-tab-icon branch February 15, 2020 02:46
lresende pushed a commit that referenced this pull request Feb 21, 2020
Unlike other tabs, prior to this any pipeline 
editor tab was missing an icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants