Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restorer to code snippet extension #553

Merged
merged 1 commit into from May 20, 2020
Merged

Add restorer to code snippet extension #553

merged 1 commit into from May 20, 2020

Conversation

marthacryan
Copy link
Member

@marthacryan marthacryan commented May 20, 2020

Adds behavior of reopening the code snippets extension on reloading
jupyter lab (if code snippets was already open). Fixes #432

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran locally and this LHTM. Though I did notice a lab bug while testing. The layout restorer doesn't restore the state of the right pane. I'll file a lab issue (and see if it's a quick fix)

@ajbozarth
Copy link
Member

The bug I mentioned is a know issue in lab jupyterlab/jupyterlab#7225 shouldn't block this PR though

@ajbozarth ajbozarth merged commit decf92c into elyra-ai:master May 20, 2020
lresende pushed a commit that referenced this pull request May 24, 2020
Adds behavior of reopening the code snippets extension on reloading
jupyter lab (if code snippets was already open). Fixes #432
@marthacryan marthacryan deleted the add-code-snippet-restorer branch July 24, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Snippets should support state restoration
3 participants